Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Use consistent naming for Django REST framework #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 2 commits into django-json-api:master from sliverc:drf_naming
Sep 18, 2021

Conversation

Copy link
Member

@sliverc sliverc commented Sep 16, 2021 •
edited
Loading

Description of the Change

This follows the naming DRF uses in its own documentation with an uppercase REST and all lowercase framework.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Copy link

codecov bot commented Sep 16, 2021 •
edited
Loading

Codecov Report

Merging #977 (aa2924f) into master (7202f42) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph 

@@ Coverage Diff @@
## master #977 +/- ##
=======================================
 Coverage 96.82% 96.82% 
=======================================
 Files 65 65 
 Lines 3904 3904 
=======================================
 Hits 3780 3780 
 Misses 124 124
Impacted Files Coverage Δ
rest_framework_json_api/settings.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7202f42...aa2924f. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, I'd argue that DRF gets it wrong and the F should be Title case....

auvipy reacted with thumbs up emoji
@n2ygk n2ygk merged commit f8209c0 into django-json-api:master Sep 18, 2021
@sliverc sliverc deleted the drf_naming branch December 28, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /