-
Notifications
You must be signed in to change notification settings - Fork 299
Use PreloadIncludesMixin for ReadOnlyModelViewSet #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #946 +/- ## ========================================== + Coverage 97.69% 97.70% +0.01% ========================================== Files 58 59 +1 Lines 3120 3134 +14 ========================================== + Hits 3048 3062 +14 Misses 72 72
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @anehx it has been a while since I reviewed one of your PRs 😄
Nice catch with this fix. Thanks. It seems that is a regression of PR #600 so since version 2.8.0. I have added checklist into your PR description to see what is missing.
As this is a regression it is actually important to add a test so this is not happening again.
Have a look at #600 where there is a test example which I guess can be done on a ReadOnlyViewSet as well. Also add yourself to AUTHORS if not done yet and add a changelog entry. Thanks.
This allows the usage of `select_for_includes` and `prefetch_for_includes` on `ReadOnlyModelViewSet`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. LGTM.
Uh oh!
There was an error while loading. Please reload this page.
Description of the Change
This allows the usage of
select_for_includesandprefetch_for_includesonReadOnlyModelViewSetChecklist
(削除) added (削除ここまで)updatedCHANGELOG.mdupdated (only for user relevant changes)AUTHORS