Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Convert HyperlinkedRelatedField tests to pytest style #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Member

@sliverc sliverc commented Feb 19, 2021

Related to #468

Description of the Change

Continuation of tests conversion

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

auvipy reacted with thumbs up emoji
@sliverc sliverc requested a review from n2ygk February 19, 2021 20:24
Copy link

codecov bot commented Feb 19, 2021 •
edited
Loading

Codecov Report

Merging #889 (22ca7c7) into master (1de9d18) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #889 +/- ##
==========================================
- Coverage 97.73% 97.70% -0.04% 
==========================================
 Files 60 59 -1 
 Lines 3269 3182 -87 
==========================================
- Hits 3195 3109 -86 
+ Misses 74 73 -1
Impacted Files Coverage Δ
tests/conftest.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de9d18...e58ea7a. Read the comment docs.

Copy link
Member Author

sliverc commented Mar 8, 2021

@n2ygk Do you think you will find time to look at this PR?

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2ygk n2ygk merged commit 3224db1 into django-json-api:master Mar 8, 2021
@sliverc sliverc deleted the hyperlinked-related-fields-tests branch December 28, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /