Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Calculate copyright date as it changes #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 1 commit into django-json-api:master from sliverc:copyright_2021
Jan 2, 2021

Conversation

Copy link
Member

@sliverc sliverc commented Jan 2, 2021

Description of the Change

A test failed as it relied on a fix copyright year. Adjusted to calculate the year.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk January 2, 2021 06:20
Copy link

codecov bot commented Jan 2, 2021 •
edited
Loading

Codecov Report

Merging #881 (1da88e2) into master (cfca644) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #881 +/- ##
=======================================
 Coverage 97.80% 97.80% 
=======================================
 Files 60 60 
 Lines 3320 3321 +1 
=======================================
+ Hits 3247 3248 +1 
 Misses 73 73
Impacted Files Coverage Δ
example/tests/test_serializers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfca644...1da88e2. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy new year!

@n2ygk n2ygk merged commit 6ea9e6a into django-json-api:master Jan 2, 2021
@sliverc sliverc deleted the copyright_2021 branch December 28, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /