Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Do not ignore F405 linting error #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 2 commits into django-json-api:master from sliverc:do_not_ignore_f405
Dec 28, 2020

Conversation

Copy link
Member

@sliverc sliverc commented Dec 11, 2020

Description of the Change

Enforces proper imports. A last follow up of #862

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk December 11, 2020 18:33
Copy link

codecov bot commented Dec 11, 2020 •
edited
Loading

Codecov Report

Merging #870 (a59c96f) into master (3833271) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #870 +/- ##
=======================================
 Coverage 97.74% 97.74% 
=======================================
 Files 60 60 
 Lines 3319 3319 
=======================================
 Hits 3244 3244 
 Misses 75 75
Impacted Files Coverage Δ
example/settings/test.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c503748...082fcad. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay. Wondering why travis is stuck....

Copy link
Contributor

n2ygk commented Dec 28, 2020

Per #877 I'm going to force merge this until we get a chance to replace travis-ci.com

@n2ygk n2ygk merged commit fdceb0a into django-json-api:master Dec 28, 2020
@sliverc sliverc deleted the do_not_ignore_f405 branch December 28, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /