Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Create tests module #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 1 commit into django-json-api:master from sliverc:tests_module
Nov 6, 2020
Merged

Create tests module #855

n2ygk merged 1 commit into django-json-api:master from sliverc:tests_module
Nov 6, 2020

Conversation

Copy link
Member

@sliverc sliverc commented Nov 4, 2020

Description of the Change

This is the basis to start migrating tests from example app.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS
 

Module used to migrate test from example
@sliverc sliverc requested a review from n2ygk November 4, 2020 19:01
Copy link

codecov bot commented Nov 4, 2020 •
edited
Loading

Codecov Report

Merging #855 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #855 +/- ##
=======================================
 Coverage 97.87% 97.87% 
=======================================
 Files 62 62 
 Lines 3443 3443 
=======================================
 Hits 3370 3370 
 Misses 73 73
Impacted Files Coverage Δ
tests/__init__.py 100.00% <ø> (ø)
tests/conftest.py 100.00% <100.00%> (ø)
example/tests/__init__.py
example/tests/conftest.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67a521...fb87e31. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2ygk n2ygk merged commit 56ef6f3 into django-json-api:master Nov 6, 2020
@sliverc sliverc deleted the tests_module branch December 28, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /