-
Notifications
You must be signed in to change notification settings - Fork 299
Define what Python, Django and DRF series are supported #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Merging #839 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #839 +/- ## ======================================= Coverage 97.76% 97.76% ======================================= Files 58 58 Lines 3089 3089 ======================================= Hits 3020 3020 Misses 69 69
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update ab3fbfc...360dcb2. Read the comment docs.
n2ygk
n2ygk
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Currently whenever a Python, Django and Django REST framework series is end of life there is a conversation on when to drop it. I think for a user of DJA it is good to have this defined to avoid surprises.
Django REST framework does not really have an end of life definition (or have I overlooked this?) so supporting the last two series is feasible. In our upcoming release 4.0.0 we actually started supporting a new DRF release and dropping all lower DRF versions. Therefore a user is forced to update DJA and DRF at the same time.
I think it is fine for this round but should be avoided this in the future.
This PR should be the basis of discussion and can also be merged after the release of 4.0.0 whatever fits best.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS