Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adjust batches #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 1 commit into django-json-api:master from sliverc:adjust_badges
Aug 26, 2020
Merged

Adjust batches #819

n2ygk merged 1 commit into django-json-api:master from sliverc:adjust_badges
Aug 26, 2020

Conversation

Copy link
Member

@sliverc sliverc commented Aug 26, 2020

Description of the Change

  • Remove gitter chat badge as not being used
  • Add PyPI badge

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

* Remove gitter chat badge as not being used
* Add PyPI badge
@sliverc sliverc requested a review from n2ygk August 26, 2020 09:01
Copy link
Member Author

sliverc commented Aug 26, 2020

@n2ygk
As additional note I am never connected to gitter. I don't know about you but I think we should not promote it when we are actually not connected.

n2ygk reacted with thumbs up emoji

Copy link

codecov bot commented Aug 26, 2020
edited
Loading

Codecov Report

Merging #819 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #819 +/- ##
=======================================
 Coverage 97.08% 97.08% 
=======================================
 Files 58 58 
 Lines 3158 3158 
=======================================
 Hits 3066 3066 
 Misses 92 92 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c49b65...016abb7. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly never even noticed that gitter link. I also don't use it either.

@n2ygk n2ygk merged commit 7458d56 into django-json-api:master Aug 26, 2020
@sliverc sliverc deleted the adjust_badges branch August 26, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /