-
Notifications
You must be signed in to change notification settings - Fork 299
Set maximum version of supported DRF and Django #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Avoid failling of master if we haven't added support for newly released versions yet.
Codecov Report
Merging #808 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #808 +/- ## ======================================= Coverage 97.45% 97.45% ======================================= Files 56 56 Lines 3068 3068 ======================================= Hits 2990 2990 Misses 78 78
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update b14d8ab...7360967. Read the comment docs.
On a side note I was just trying to add Django 3.1 support to DJA. DRF raises quite a few deprecation warnings so we need to wait for a new DRF version anyway before we support Django 3.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not drop django below 2.2 and add support for 3.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only drop support for Django 1.11 once DRF 3.12 is released as earlier versions still support 1.11. And Django 3.1 can not yet be supported as I have commented above
@onurhunce
onurhunce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to merge this one since it blocks running the example app :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uh oh!
There was an error while loading. Please reload this page.
Fixes #803
Avoid failling of master if we haven't added support for newly released versions yet.
Description of the Change
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS