Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Make isort test properly run again within Travis #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 5 commits into django-json-api:master from sliverc:isort_issue
Jun 8, 2020

Conversation

Copy link
Member

@sliverc sliverc commented May 25, 2020 •
edited
Loading

Description of the Change

Travis has build in its path name and therefore files got skipped from isort. To avoid this we only skip build/lib which is used by bdist command.

This PR fixes the already invalidly committed imports and cleans up obsolete linting settings.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc force-pushed the isort_issue branch 2 times, most recently from b8b6376 to 24e4953 Compare May 25, 2020 15:51
Copy link

codecov bot commented May 25, 2020 •
edited
Loading

Codecov Report

Merging #792 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #792 +/- ##
=======================================
 Coverage 97.39% 97.39% 
=======================================
 Files 56 56 
 Lines 2989 2989 
=======================================
 Hits 2911 2911 
 Misses 78 78
Impacted Files Coverage Δ
example/tests/unit/test_renderers.py 100.00% <100.00%> (ø)
rest_framework_json_api/renderers.py 87.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a27cc1...66de525. Read the comment docs.

@sliverc sliverc force-pushed the isort_issue branch 10 times, most recently from 729e622 to 70e2f0f Compare May 26, 2020 09:05
sliverc added 3 commits May 26, 2020 19:56 
Travis has `build` in its path name and therefore files got skipped from
isort. To avoid this we only skip `build/lib` which is used by
bdist command.
@sliverc sliverc changed the title (削除) Test linting (削除ここまで) (追記) Make isort test properly run again within Travis (追記ここまで) May 26, 2020
@sliverc sliverc marked this pull request as ready for review May 26, 2020 18:11
@sliverc sliverc requested a review from n2ygk May 26, 2020 18:12
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2ygk n2ygk merged commit f87eeaf into django-json-api:master Jun 8, 2020
@sliverc sliverc deleted the isort_issue branch December 28, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /