Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replace old setting reference in documentation #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 2 commits into django-json-api:master from sliverc:correct_doc_format_names
Jun 8, 2020

Conversation

Copy link
Member

@sliverc sliverc commented May 22, 2020

Description of the Change

FORMAT_KEYS has been removed in version 3.0 and only
setting JSON_API_FORMAT_FIELD_NAMES is now available.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

`FORMAT_KEYS` has been removed in version 3.0 and only
setting `JSON_API_FORMAT_FIELD_NAMES` is now available.
@sliverc sliverc requested a review from n2ygk May 22, 2020 19:55
Copy link

codecov bot commented May 22, 2020
edited
Loading

Codecov Report

Merging #791 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #791 +/- ##
=======================================
 Coverage 97.39% 97.39% 
=======================================
 Files 56 56 
 Lines 2989 2989 
=======================================
 Hits 2911 2911 
 Misses 78 78 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a30c381...5fcf191. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2ygk n2ygk merged commit 6a27cc1 into django-json-api:master Jun 8, 2020
@sliverc sliverc deleted the correct_doc_format_names branch December 28, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /