Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Reimplement SerializerMethodResourceRelatedField #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sliverc merged 4 commits into django-json-api:master from glowka:serializer-method-field
May 3, 2020

Conversation

Copy link
Contributor

@glowka glowka commented Apr 15, 2020 •
edited
Loading

Description of the Change

Fixes #639 - interface not consistent with SerializerMethodField
Fixes #779 - no enforcement of read_only
Fixes #780 - broken parent chain

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

David-Guillot reacted with hooray emoji
@glowka glowka force-pushed the serializer-method-field branch from 38e7dba to 3664a01 Compare April 15, 2020 20:35
Copy link

codecov bot commented Apr 15, 2020 •
edited
Loading

Codecov Report

Merging #781 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #781 +/- ##
==========================================
+ Coverage 97.21% 97.32% +0.11% 
==========================================
 Files 55 56 +1 
 Lines 2874 2920 +46 
==========================================
+ Hits 2794 2842 +48 
+ Misses 80 78 -2
Impacted Files Coverage Δ
example/tests/test_relations.py 100.00% <ø> (ø)
example/tests/test_parsers.py 100.00% <100.00%> (ø)
example/tests/test_serializers.py 100.00% <100.00%> (ø)
example/tests/unit/test_serializer_method_field.py 100.00% <100.00%> (ø)
rest_framework_json_api/relations.py 88.62% <100.00%> (+1.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdf461...f03dbba. Read the comment docs.

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this. This looks really good. There is currently no documentation about this field though so could you add an example into the documentation and add a changelog entry?

Thanks.

@glowka glowka force-pushed the serializer-method-field branch from 3664a01 to 4f79464 Compare April 22, 2020 20:51
@glowka glowka requested a review from sliverc April 22, 2020 21:00
@sliverc sliverc changed the title (削除) Reimlement SerializerMethodResourceRelatedField (削除ここまで) (追記) Reimplement SerializerMethodResourceRelatedField (追記ここまで) May 3, 2020
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thanks.

glowka reacted with laugh emoji
@sliverc sliverc merged commit 1dccbb0 into django-json-api:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliverc sliverc sliverc approved these changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone

AltStyle によって変換されたページ (->オリジナル) /