-
Notifications
You must be signed in to change notification settings - Fork 299
Enforce conflict response when requested PATCH resource object is unequal to endpoint #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A server MUST return 409 Conflict when processing a PATCH request in which the resource object’s type and id do not match the server’s endpoint.
Codecov Report
Merging #763 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #763 +/- ## ======================================= Coverage 97.12% 97.12% ======================================= Files 54 54 Lines 2787 2787 ======================================= Hits 2707 2707 Misses 80 80
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update c51f6b9...7977c00. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this great addition to DJA. I always like to see PRs making DJA follow the JSON API spec more closely.
I have added some comments. Additionally in the body I have also added the pull request template again with the checklist. Could you add yourself to AUTHORS list as well and add a changelog entry?
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Uh oh!
There was an error while loading. Please reload this page.
Description of the Change
A server MUST return 409 Conflict when processing a PATCH request in which the resource object’s type and id do not match the server’s endpoint.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS