Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Properly return parser error when primary data is of invalid type #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sliverc merged 5 commits into django-json-api:master from bpleshakov:patch-1
Jan 23, 2020

Conversation

Copy link
Contributor

@bpleshakov bpleshakov commented Jan 16, 2020

If you submit a list with one object, for example, drf_json_api will respond to you with unobvious errors.

Copy link

codecov bot commented Jan 16, 2020
edited
Loading

Codecov Report

Merging #762 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@
## master #762 +/- ##
==========================================
+ Coverage 97.12% 97.13% +<.01% 
==========================================
 Files 54 54 
 Lines 2787 2795 +8 
==========================================
+ Hits 2707 2715 +8 
 Misses 80 80
Impacted Files Coverage Δ
example/tests/test_parsers.py 100% <100%> (ø) ⬆️
rest_framework_json_api/parsers.py 97.43% <100%> (+0.06%) ⬆️
example/factories.py 100% <0%> (ø) ⬆️
example/tests/conftest.py 100% <0%> (ø) ⬆️
example/tests/integration/test_pagination.py 100% <0%> (ø) ⬆️
example/api/resources/identity.py 100% <0%> (ø) ⬆️
example/tests/unit/test_default_drf_serializers.py 100% <0%> (ø) ⬆️
example/tests/unit/test_utils.py 100% <0%> (ø) ⬆️
.../tests/integration/test_non_paginated_responses.py 100% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96aaa13...5d25394. Read the comment docs.

Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to increase code coverage.

Boris Pleshakov and others added 5 commits January 23, 2020 21:40
@sliverc sliverc changed the title (削除) Create/update validation that "data" key is object (削除ここまで) (追記) Properly return parser error when primary data is of invalid type (追記ここまで) Jan 23, 2020
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks.

@sliverc sliverc merged commit d5d7215 into django-json-api:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliverc sliverc sliverc approved these changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /