Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Adjust invalid field_name_mapping example for related fields #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 5 commits into django-json-api:master from sliverc:clarify_docs
Jan 17, 2020

Conversation

Copy link
Member

@sliverc sliverc commented Dec 16, 2019

Fixes #748

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Copy link

codecov bot commented Dec 16, 2019 •
edited
Loading

Codecov Report

Merging #756 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #756 +/- ##
==========================================
+ Coverage 97.08% 97.12% +0.03% 
==========================================
 Files 54 54 
 Lines 2742 2779 +37 
==========================================
+ Hits 2662 2699 +37 
 Misses 80 80
Impacted Files Coverage Δ
rest_framework_json_api/renderers.py 87.05% <ø> (+0.25%) ⬆️
example/api/resources/identity.py 100% <ø> (ø) ⬆️
example/tests/test_model_viewsets.py 100% <ø> (ø) ⬆️
example/tests/test_format_keys.py 100% <ø> (ø) ⬆️
example/tests/test_sideload_resources.py 100% <ø> (ø) ⬆️
rest_framework_json_api/metadata.py 91.66% <100%> (ø) ⬆️
rest_framework_json_api/relations.py 87.31% <100%> (+0.12%) ⬆️
rest_framework_json_api/exceptions.py 84.61% <100%> (ø) ⬆️
example/factories.py 100% <0%> (ø) ⬆️
example/tests/conftest.py 100% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ede7f7...169838a. Read the comment docs.

@sliverc sliverc changed the title (削除) Adjust invalid field_name_mapping example for related fieds (削除ここまで) (追記) Adjust invalid field_name_mapping example for related fields (追記ここまで) Dec 16, 2019
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sorry for the delay in getting to this.

@n2ygk n2ygk merged commit 0c587ac into django-json-api:master Jan 17, 2020
@sliverc sliverc deleted the clarify_docs branch December 28, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misleading docs on field_name_mapping for overriding related_field in urls

AltStyle によって変換されたページ (->オリジナル) /