Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Clarify recommendation to use latest patch release #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 2 commits into django-json-api:master from sliverc:clarify_patch_release
Oct 10, 2019

Conversation

Copy link
Member

@sliverc sliverc commented Oct 9, 2019

Description of the Change

Follow the same recommendation concerning patch release of dependencies as Django REST Framework does.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk October 9, 2019 06:25
Copy link

codecov bot commented Oct 9, 2019
edited
Loading

Codecov Report

Merging #719 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #719 +/- ##
=======================================
 Coverage 97.08% 97.08% 
=======================================
 Files 54 54 
 Lines 2742 2742 
=======================================
 Hits 2662 2662 
 Misses 80 80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1753fe9...1a6824e. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2ygk n2ygk merged commit 7655f02 into django-json-api:master Oct 10, 2019
@sliverc sliverc deleted the clarify_patch_release branch December 28, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /