-
Notifications
You must be signed in to change notification settings - Fork 299
Use extra requires to separate optional features #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+36
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sliverc
sliverc
force-pushed
the
extra_requires
branch
from
October 3, 2019 15:46
117e376 to
70df0c2
Compare
Fixes django-json-api#674 Currently only django-filter and django-polymorphic use the extra_requires definition.
@sliverc
sliverc
force-pushed
the
extra_requires
branch
from
October 3, 2019 16:25
70df0c2 to
4b26a08
Compare
n2ygk
n2ygk
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for doing the extra-require stuff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #674
Currently only django-filter and django-polymorphic use the extra_requires definition.
PR includes some small on the fly documentation changes.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS