Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Format metadata field names correctly for OPTIONS request #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sliverc merged 3 commits into django-json-api:master from sliverc:format-metadata-fieldnames
Oct 3, 2019

Conversation

Copy link
Member

@sliverc sliverc commented Oct 2, 2019

Supersedes #500

Description of the Change

Take into account setting JSON_API_FORMAT_FIELD_NAMES

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS
 

Take into account settings JSON_API_FORMAT_FIELD_NAMES
Copy link

codecov bot commented Oct 3, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b3cacb7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #713 +/- ##
=========================================
 Coverage ? 97.08% 
=========================================
 Files ? 54 
 Lines ? 2742 
 Branches ? 0 
=========================================
 Hits ? 2662 
 Misses ? 80 
 Partials ? 0
Impacted Files Coverage Δ
example/tests/test_format_keys.py 100% <100%> (ø)
rest_framework_json_api/metadata.py 91.66% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3cacb7...69c5101. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suppose long-term we should discuss about whether OPTIONS should return an OAS schema or something more standard.

sliverc reacted with thumbs up emoji
@sliverc sliverc merged commit b99bfe4 into django-json-api:master Oct 3, 2019
@sliverc sliverc deleted the format-metadata-fieldnames branch October 3, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /