-
Notifications
You must be signed in to change notification settings - Fork 298
Avoid exception when using ResourceIdentifierObjectSerializer with unexisting primary key
#690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #690 +/- ## ========================================== + Coverage 95.96% 95.97% +0.01% ========================================== Files 54 54 Lines 2727 2735 +8 ========================================== + Hits 2617 2625 +8 Misses 110 110
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #690 +/- ## ========================================= Coverage ? 95.97% ========================================= Files ? 54 Lines ? 2735 Branches ? 0 ========================================= Hits ? 2625 Misses ? 110 Partials ? 0
Continue to review full report at Codecov.
|
@n2ygk Could you have a look at this PR? Thanks.
@n2ygk Could you have a look at this PR? Thanks.
@sliverc Will do. Sometimes I miss these assignment emails because I subscribe to all activity. I'll make a tickler to regularly check https://github.com/pulls/review-requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks good. Sorry for the delay in reviewing this.
Fixes #683
Description of the Change
Because of star import linting didn't realize that
ObjectDoesNotExistexception was not properly imported.Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS