replace DRF @list_route and @detail_route with @action #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

n2ygk wants to merge 1 commit into django-json-api:master from n2ygk:issue-657/drf_decorators

Closed

replace DRF @list_route and @detail_route with @action #659

n2ygk wants to merge 1 commit into django-json-api:master from n2ygk:issue-657/drf_decorators

Conversation

n2ygk

Copy link

Contributor

@n2ygk n2ygk commented Jun 7, 2019

Fixes #657

Description of the Change

DRF 3.10 milestone has dropped the @list_route and @detail_route decorators and replaced them with @action(detail=False) or @action(detail=True) which was added in DRF 3.8.

This fix handles both DRF<=3.7 and >=3.8 cases.

Checklist

PR only contains one change (considered splitting up PR)
unit-test added
documentation updated
CHANGELOG.md updated (only for user relevant changes)
author name in AUTHORS

@n2ygk n2ygk requested a review from sliverc

June 7, 2019 18:02

@n2ygk

Copy link

Contributor Author

n2ygk commented Jun 7, 2019

@sliverc any idea why the codecov statuses appear to be stuck?

@n2ygk


 replace @list_route and @detail_route with @action due to DRF depreca...

08cb73f

...tion

@n2ygk n2ygk force-pushed the issue-657/drf_decorators branch from a160bdf to 08cb73f Compare

June 9, 2019 17:23

@codecov

Copy link

codecov bot commented Jun 9, 2019

Codecov Report

Merging #659 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@
## master #659 +/- ##
==========================================
- Coverage 96.15% 96.14% -0.02% 
==========================================
 Files 57 56 -1 
 Lines 2889 2876 -13 
==========================================
- Hits 2778 2765 -13 
 Misses 111 111

Impacted Files	Coverage Δ
example/api/resources/identity.py	`100% <100%> (ø)`	⬆️
example/tests/integration/test_polymorphism.py	`100% <0%> (ø)`	⬆️
example/models.py	`100% <0%> (ø)`	⬆️
example/migrations/0007_artproject_description.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7abd764...08cb73f. Read the comment docs.

1 similar comment

@codecov

Copy link

codecov bot commented Jun 9, 2019

Codecov Report

Merging #659 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@
## master #659 +/- ##
==========================================
- Coverage 96.15% 96.14% -0.02% 
==========================================
 Files 57 56 -1 
 Lines 2889 2876 -13 
==========================================
- Hits 2778 2765 -13 
 Misses 111 111

Impacted Files	Coverage Δ
example/api/resources/identity.py	`100% <100%> (ø)`	⬆️
example/tests/integration/test_polymorphism.py	`100% <0%> (ø)`	⬆️
example/models.py	`100% <0%> (ø)`	⬆️
example/migrations/0007_artproject_description.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7abd764...08cb73f. Read the comment docs.