-
Notifications
You must be signed in to change notification settings - Fork 299
Patch request with "meta" attribute fails #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the specification only name type
and id
are not allowed but meta should be. See https://jsonapi.org/format/#document-resource-object-fields
This might be a bit tricky to implement though.
@czosel
Feel free to work on it if you find time.
As this is an unfinished PR I have created an issue #710 referencing this PR as example.
Closing this PR but contributions are still welcome 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
(This is actually more an issue instead of a PR, but since I have a failing test, I figured I'd post this as a PR anyway.)
When
meta
is used as attribute name,PATCH
requests are failing because the attribute's value is used in a code path which is supposed to handle the top-levelmeta
property.Request body (taken from the test case):
Exception:
I didn't find any note that
meta
should not be used as attribute name. If that actually is advised, it would be great to check the models and throw an Error if a model/serializer with ameta
property is found.