Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Pin django-debug-toolbar version to fix Python 2.7 tests #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 1 commit into django-json-api:master from sliverc:debugtoolbar
May 24, 2019

Conversation

Copy link
Member

@sliverc sliverc commented May 21, 2019

Description of the Change

Pin django debug toolbar to fix tests in master.

This is a quick fix and at a later point we should try to avoid having debug toolbar as dependency for tests. A bit more complicated to fix as example and tests are combined.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Copy link

codecov bot commented May 21, 2019
edited
Loading

Codecov Report

Merging #634 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #634 +/- ##
=======================================
 Coverage 95.66% 95.66% 
=======================================
 Files 56 56 
 Lines 2861 2861 
=======================================
 Hits 2737 2737 
 Misses 124 124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db5cd72...2fdd4d3. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see it was pinned in requirements-development.txt but not here. LGTM.

@n2ygk n2ygk merged commit ba16324 into django-json-api:master May 24, 2019
@sliverc sliverc deleted the debugtoolbar branch May 24, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /