Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

import missing six #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sliverc merged 1 commit into django-json-api:master from n2ygk:issue-629/six
May 15, 2019
Merged

import missing six #630

sliverc merged 1 commit into django-json-api:master from n2ygk:issue-629/six
May 15, 2019

Conversation

Copy link
Contributor

@n2ygk n2ygk commented May 14, 2019

Fixes #629

Description of the Change

import six since it's no longer in DRF as of 3.10.

Checklist

  • [x ] PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • [ x] author name in AUTHORS

leo-naeka reacted with thumbs up emoji
Copy link

codecov bot commented May 14, 2019
edited
Loading

Codecov Report

Merging #630 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #630 +/- ##
=======================================
 Coverage 95.65% 95.65% 
=======================================
 Files 55 55 
 Lines 2856 2856 
=======================================
 Hits 2732 2732 
 Misses 124 124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e65a1...2dd222d. Read the comment docs.

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's merge this. Once DRF 3.10 is released we should also discuss how we move on concerning Py27 support.

@sliverc sliverc merged commit 4c22087 into django-json-api:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliverc sliverc sliverc approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@six gone missing with DRF 3.10.x
2 participants

AltStyle によって変換されたページ (->オリジナル) /