-
Notifications
You must be signed in to change notification settings - Fork 298
Avoid printing invalid pointer when api returns 404 #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #599 +/- ## ========================================== - Coverage 96.11% 95.98% -0.14% ========================================== Files 56 56 Lines 2859 2866 +7 ========================================== + Hits 2748 2751 +3 - Misses 111 115 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution and well spotted, the pointer is invalid indeed.
The specification doesn't specifically clarify what to do in case of a 404 error. In this discussion though they suggest not to add a pointer in case of 404. Sounds kind of logical to me as there is not data actually returned so they can't be a pointer.
Could you adjust your PR so it doesn't add a pointer in case of 404?
3f804c9 to
7464deb
Compare
I've removed the source entirely for 404 errors.
7464deb to
b27c84d
Compare
b27c84d to
061ffd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Fixes the pointer for 404 results.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS