Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Mark or remove uncovered example code #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 1 commit into django-json-api:master from sliverc:not_covered_example_code
Jan 4, 2019

Conversation

Copy link
Member

@sliverc sliverc commented Jan 4, 2019

A next step to clean up coverage.

@sliverc sliverc requested a review from n2ygk January 4, 2019 09:21
Copy link

codecov bot commented Jan 4, 2019 •
edited
Loading

Codecov Report

Merging #542 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #542 +/- ##
=========================================
+ Coverage 95.54% 95.6% +0.05% 
=========================================
 Files 55 55 
 Lines 2853 2843 -10 
=========================================
- Hits 2726 2718 -8 
+ Misses 127 125 -2
Impacted Files Coverage Δ
example/tests/conftest.py 100% <ø> (ø) ⬆️
.../tests/integration/test_non_paginated_responses.py 100% <ø> (ø) ⬆️
example/tests/integration/test_pagination.py 100% <ø> (ø) ⬆️
example/tests/test_serializers.py 100% <ø> (ø) ⬆️
example/factories.py 100% <ø> (+1.23%) ⬆️
example/tests/unit/test_renderer_class_methods.py 100% <ø> (+1.4%) ⬆️
example/tests/unit/test_default_drf_serializers.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 517511f...af2d64f. Read the comment docs.

@sliverc sliverc force-pushed the not_covered_example_code branch from a338d67 to af2d64f Compare January 4, 2019 09:47
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2ygk n2ygk merged commit 70be81b into django-json-api:master Jan 4, 2019
@sliverc sliverc deleted the not_covered_example_code branch January 4, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /