Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Removed hardcoded year 2018 from tests (#539) #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 2 commits into django-json-api:master from hb9hnt:issue-539
Jan 3, 2019

Conversation

Copy link
Contributor

@hb9hnt hb9hnt commented Jan 2, 2019 •
edited by n2ygk
Loading

Fixes #539

Description of the Change

Replaced the hardcoded year 2018 with datetime.now().year in all four tests which failed.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS (Already included in another pull request.)

Copy link

codecov bot commented Jan 2, 2019 •
edited
Loading

Codecov Report

Merging #541 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 95.46% 95.47% +<.01% 
==========================================
 Files 54 54 
 Lines 2802 2804 +2 
==========================================
+ Hits 2675 2677 +2 
 Misses 127 127
Impacted Files Coverage Δ
example/tests/unit/test_default_drf_serializers.py 100% <100%> (ø) ⬆️
example/tests/test_views.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6518cdb...1194c12. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @PUREMATH. Please add your name to AUTHORS for this PR since the other has not yet been merged. This will be an easy merge once you've done that. Thanks!

@n2ygk n2ygk merged commit 11e0edd into django-json-api:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /