-
Notifications
You must be signed in to change notification settings - Fork 298
Avoid exception in AutoPrefetchMixin when including a reverse one to one relation
#536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid exception in AutoPrefetchMixin when including a reverse one to one relation
#536
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #536 +/- ## ========================================== + Coverage 94.33% 94.34% +0.01% ========================================== Files 60 61 +1 Lines 3725 3750 +25 ========================================== + Hits 3514 3538 +24 - Misses 211 212 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #536 +/- ## ========================================== + Coverage 95.47% 95.51% +0.04% ========================================== Files 54 55 +1 Lines 2804 2829 +25 ========================================== + Hits 2677 2702 +25 Misses 127 127
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Fix looks good to me, there is just one question concerning test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when authors.bio.metadata is requested to be included shouldn't there be a authorsBioMetadata type be included as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added AuthorBiosMetadata on Serializarers. I change the tests to reflect that.
AutoPrefetchMixin when including a reverse one to one relation (追記ここまで)
@santiavenda2
Merged. Thanks for your contribution.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #537
Description of the Change
Fix AutoPrefetchMixin when include have a one to one relation
Checklist
CHANGELOG.mdAUTHORS