Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Refactor backends to filters + bugfix #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sliverc merged 2 commits into django-json-api:master from n2ygk:refactor_backends_filters
Aug 23, 2018

Conversation

Copy link
Contributor

@n2ygk n2ygk commented Aug 22, 2018

Fixes #459

Description of the Change

  • renamed from backends to filters
  • bugfix: camelcase, etc. sort parameters were being ignored.
  • support for sorting via relationship paths.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md (in JSONAPIOrderingFilter #459 )
  • author name in AUTHORS

n2ygk added 2 commits August 22, 2018 10:48 
Also added more test_cases and suppor for sorting via relationship paths.
@n2ygk n2ygk requested a review from sliverc August 22, 2018 21:24
Copy link

codecov-io commented Aug 22, 2018 •
edited
Loading

Codecov Report

Merging #464 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #464 +/- ##
==========================================
+ Coverage 93.37% 93.44% +0.07% 
==========================================
 Files 56 56 
 Lines 3183 3217 +34 
==========================================
+ Hits 2972 3006 +34 
 Misses 211 211
Impacted Files Coverage Δ
example/settings/dev.py 100% <ø> (ø) ⬆️
rest_framework_json_api/filters.py 100% <100%> (ø)
example/views.py 92% <100%> (+0.1%) ⬆️
example/tests/test_filters.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6290af...d77b17a. Read the comment docs.

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good.

@sliverc sliverc merged commit 17d65b8 into django-json-api:master Aug 23, 2018
@n2ygk n2ygk added this to the 2.6.0 milestone Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliverc sliverc sliverc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /