-
Notifications
You must be signed in to change notification settings - Fork 299
Drf example fixtures #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drf example fixtures #462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend using a JSON fixture instead of YAML to avoid the extra dependency on PyYAML for the example app. Otherwise, LGTM. 👍
Codecov Report
Merging #462 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #462 +/- ## ======================================= Coverage 93.24% 93.24% ======================================= Files 54 54 Lines 3123 3123 ======================================= Hits 2912 2912 Misses 211 211
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 8821b99...2c6de09. Read the comment docs.
Description of the Change
I've always been uncomfortable with the
drf_examplesqlite3 db binary file:which includes a few rows of sample data.
This PR replaces it with a fixture. This adds one step to getting-started but makes it much more clear what the sample data is (and easier to maintain) .
Checklist
CHANGELOG.mdAUTHORS