Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use tox to run test in travis #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sliverc merged 2 commits into django-json-api:master from sliverc:use_tox_in_travis
Jun 13, 2018

Conversation

Copy link
Member

@sliverc sliverc commented Jun 12, 2018

This way we can harmonize tox and travis configuration

Fixes #391

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added (not needed as only build change)
  • documentation updated (not needed as only build change)
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

This way we can harmonize tox and travis configuration
Copy link
Collaborator

@mblayman mblayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice!

Copy link

codecov-io commented Jun 13, 2018
edited
Loading

Codecov Report

Merging #440 into master will increase coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #440 +/- ##
=========================================
+ Coverage 91.95% 92.6% +0.65% 
=========================================
 Files 57 54 -3 
 Lines 2994 2812 -182 
=========================================
- Hits 2753 2604 -149 
+ Misses 241 208 -33
Impacted Files Coverage Δ
example/api/serializers/__init__.py
example/migrations/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea4743...0f01240. Read the comment docs.

@sliverc sliverc changed the title (削除) WIP: Use tox to run test in travis (削除ここまで) (追記) Use tox to run test in travis (追記ここまで) Jun 13, 2018
Copy link
Member Author

sliverc commented Jun 13, 2018

@mblayman I would have been too lucky to get it right in the first run. Coverage was not working anymore and is now fixed. Could you have a look again? Thanks.

Copy link
Collaborator

@mblayman mblayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me. Thanks for doing this one. I think it will help the tox file stay up-to-date. 👍

@sliverc sliverc merged commit 2b6a72c into django-json-api:master Jun 13, 2018
@sliverc sliverc deleted the use_tox_in_travis branch December 28, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mblayman mblayman mblayman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /