-
Notifications
You must be signed in to change notification settings - Fork 298
Don't output key for write only relations #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't output key for write only relations #421
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #421 +/- ## ========================================== - Coverage 93.1% 93.07% -0.03% ========================================== Files 54 54 Lines 3000 3002 +2 ========================================== + Hits 2793 2794 +1 - Misses 207 208 +1
Continue to review full report at Codecov.
|
Thanks for your contribution. Looks good to me but could you write a test case for this? Thanks.
Closing this PR in favor of #522
If the
write_onlykey isTrueon a relationship, its key is still included in the response body with an empty resource object ({'data': null}).This was fixed in #230 for normal fields but not for relations.