-
Notifications
You must be signed in to change notification settings - Fork 299
Remove factory-boy version constraint. #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mblayman
merged 4 commits into
django-json-api:master
from
mblayman:remove-factory-boy-constraint
Feb 1, 2018
Merged
Remove factory-boy version constraint. #408
mblayman
merged 4 commits into
django-json-api:master
from
mblayman:remove-factory-boy-constraint
Feb 1, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that pytest-factoryboy now works with a new version of pytest.
codecov-io
commented
Feb 1, 2018
Codecov Report
@@ Coverage Diff @@ ## master #408 +/- ## ========================================== - Coverage 91.93% 91.79% -0.14% ========================================== Files 55 55 Lines 2925 2925 ========================================== - Hits 2689 2685 -4 - Misses 236 240 +4
Continue to review full report at Codecov.
|
This makes the test suite green again so I'm going to go ahead and merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #407 is failing CI currently because of a package version issue and the PR is only changing a typo in the usage file. Some dependency requirement must have changed recently.
I'm trying this PR to see if it's now possible to have factory-boy working on a newer version.