Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix import NoReverseMatch #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mapeveri wants to merge 1 commit into django-json-api:develop from mapeveri:develop

Conversation

Copy link

@mapeveri mapeveri commented Dec 2, 2017

Could you please tell me when you will release a new version?

Copy link
Collaborator

mblayman commented Dec 3, 2017

@mapeveri Thanks for the contribution. This branch is currently failing on the import sort order. The fix looks good to me so I'm happy to merge it once the import order is updated (please see a CI build for detail).

Copy link
Author

mapeveri commented Dec 3, 2017

@mblayman I don't understand because this PR failed. I just modified the tests, but it's not that :(

The strange thing is that in travis it's ok. I do not understand where the error is.

image

Copy link
Collaborator

mblayman commented Dec 3, 2017

The CI build runs more than tests. If you look at some of the builds, you can observe some flake8 failures.
image

Copy link
Collaborator

mblayman commented Dec 5, 2017
edited
Loading

I've had more time to think on this PR. This import fix is solving a problem that will affect Django 2.0 users (because the old import moved). The currently released version of DJA (2.3.1) does not officially support DRF 3.7.x. The DRF 3.6.x series does not support Django 2.0 (and I don't think it ever will).

PR #387 removes support for the older versions of Django where this older import is required. I think DRF 3.7 support will come after that and, with that, Django 2.0 compatibility.

In light of all of that version information, I think it makes sense to close this PR (and its cousin, #392) in favor of #387. DJA 2.4.x will be the first version to support DRF 3.7.x and Django 2.0.

Even though I won't be merging this PR, I totally appreciate your effort. It lit the fire under me to get out the 2.3.1 DJA release and motivated me to get DJA compatible with the latest versions in the Django ecosystem. Thanks a ton!

lucacorti reacted with thumbs up emoji

Copy link
Author

mapeveri commented Dec 5, 2017

@mblayman When the version that supports Django 2.0 comes out? I mean the date aprox. Thanks!!

Copy link
Collaborator

mblayman commented Dec 5, 2017

I don't know for certain, however, I'd hope to have it done before the new year.

Copy link
Author

mapeveri commented Dec 5, 2017

@mblayman great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /