-
Notifications
You must be signed in to change notification settings - Fork 299
Fix for resolving source when accessing sub-attr eg b.c #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ping!. Is there anything else which needs to be done to merge this PR?
Hi, @cosmosgenius, thanks for your patience. Anyone working on this project is purely a volunteer so I guess we've all been fairly busy lately. Through no fault of your own, the tests are all failing. I believe this is because of a dependency problem that was resolved recently. Could you merge the latest develop into this branch? The project policy is to merge PRs only when they pass all tests. Once this branch is passing, I'm happy to merge as the fix content looks good. Thanks! 👍
19867df to
c0b580c
Compare
c0b580c to
72d4588
Compare
codecov-io
commented
Nov 15, 2017
Codecov Report
@@ Coverage Diff @@ ## develop #375 +/- ## =========================================== + Coverage 93.05% 93.06% +<.01% =========================================== Files 51 51 Lines 2665 2666 +1 =========================================== + Hits 2480 2481 +1 Misses 185 185
Continue to review full report at Codecov.
|
@mblayman no issues. Just checking up :). I have rebased the branch with the latest develop and fixed an isort issue. Let me know if anything else is required.
Awesome. Thanks, @cosmosgenius!
Uh oh!
There was an error while loading. Please reload this page.
planis a field of another serializer which needs to be resolved usingobj.subscription.planproperty. It works for standard DRF JSON response but fails in drf-json-api.This PR fixes that issue by replacing
getattrwithoperator.attrgetterwhich is able to resolve the sub-attr access.