-
Notifications
You must be signed in to change notification settings - Fork 298
[WIP] Fix example app #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## develop #362 +/- ## =========================================== + Coverage 92.81% 92.86% +0.05% =========================================== Files 51 51 Lines 2644 2650 +6 =========================================== + Hits 2454 2461 +7 + Misses 190 189 -1
Continue to review full report at Codecov.
|
@leo-naeka if you know this better, I would love some insight. I'm not actually that familiar with DRF.
I'll check this today.
Actually the ImproperlyConfigured at /entries: Could not resolve URL for hyperlinked relationship using view name "entry-relationships".
bug was introduced before the polymorphic feature merge: occurs in 629d1d6.
The last error is polymorphic-related indeed.
@Darkheir, one of the errors that's happening on the demo site might be related one of your commits. Could you take a look at the issue? Once we fix the demo site, I'd love to put out a release that includes everyone's work from the last couple of months.
Hi,
I quickly checked using the debugger and the code I added is not called during the process ...
After some investigation this endpoint may have been errored since Nov. 8th 2016 with commit 1941c34.
- 1941c34 introduced the
Could not resolve URL for hyperlinked relationship using view name "entry-relationships".
- fbe49a1 introduced the
'EntrySerializer' object has no attribute 'partial'
error which supersede 1941c34's one but occurred only withDRF>=3.6.3
- a12d98d fixed the
'EntrySerializer' object has no attribute 'partial'
and we got back the first one 'til now...
The fact is that relationship patterns are not included in regular urls.py
as they are in urls_test.py
. I'm not very familiar with the relationships code, but adding them seems to fix the bug...
@astronouth7303 found the bug in the PolymorphicModelSerializer
causing the last error. Fixed and added a test case locally. Could you please grant me push to your repo in order to fix all of these in this PR?
@leo-naeka I won't have much time to look at this for a while, but I hope to give it some more time in the future. I took a quick peek and I have a question. What do you mean by "missing relationship patterns"? The second bullet is an error with /entries
and it looks like that is in urls.py
. I'm not clear on your meaning of "missing" in this context.
btw, thanks for looking into these issues!
Could we solve the remaining problems by moving the routes from the tests to the regular urls.py
file? I think this branch has made things better and if moving the routes is something that would fix the demo site, then I think that would be good enough to merge so we can get closer to releasing.
Time flies. I think this code is good enough to merge because it solved some problem. Since there hasn't been movement on the remaining task, I'll merge and we can solve that later.
Uh oh!
There was an error while loading. Please reload this page.
Some miscellaneous bugs, some of which stemmed from polymorphic. Fixes #356
packaging
(example/serializers.py
). I'm guessing this is the actual cause of the bug./entries
producesImproperlyConfigured at /entries
:Could not resolve URL for hyperlinked relationship using view name "entry-relationships".
/projects
producesAttributeError at /projects
:'list' object has no attribute '_meta'