-
Notifications
You must be signed in to change notification settings - Fork 299
Fixes types in reverse m2m relationships #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixes #354
It seems that my new test triggers an error on Django 1.8 version.
The error is not on the lines added by my commits, but I will try to fix it
Codecov Report
@@ Coverage Diff @@ ## develop #355 +/- ## =========================================== + Coverage 77.06% 77.11% +0.04% =========================================== Files 50 50 Lines 6027 6038 +11 =========================================== + Hits 4645 4656 +11 Misses 1382 1382
Continue to review full report at Codecov.
|
Hi, @Darkheir. Thanks so much for your contribution! The extra test coverage is really valued. I like the code that I see here. I'd like for all contributors to be recognized for their work so could you add your name to the AUTHORS file? The list of names is alphabetical by first name.
I'm happy to merge after that.
Hi, thank you for your kind answer. I just added my name to the contributors.
Great, thanks again!
In case of reverse m2m relationships the wrong type was returned.
I created a test to reproduce this situation.