-
Notifications
You must be signed in to change notification settings - Fork 298
Enforcing of flake8 linter #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Allow F405 (star imports) as this is part of drf json api concept * Remove E501 so defined max-line-length won't be ignored
Codecov Report
@@ Coverage Diff @@ ## develop #348 +/- ## ========================================== + Coverage 76.45% 76.86% +0.4% ========================================== Files 50 50 Lines 6036 6013 -23 ========================================== + Hits 4615 4622 +7 + Misses 1421 1391 -30
Continue to review full report at Codecov.
|
@sliverc, This is really good stuff! Thank you very much for this contribution. Could I make two additional requests?
- Could you add your name to the AUTHORS file to acknowledge your contribution? This is a community project and I think everyone should be recognized for their work.
- Could you add an entry to the CHANGELOG for version v2.3.0?
Once those things happen, I'm happy to merge this. 👍
@mblayman Thanks. Adjusted as requested.
When I created PR #347 I noticed many flake8 linting errors and it was difficult to differentiate between the errors I have possibly made in my new code block and errors which have been there before.
To avoid this and improve code quality I have adjusted the code so flake8 linting is enforced by CI. I have used autopep8 and some manual adjustments to do so.
Following flake8 flags changed: