Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix JSONRenderer when status_code is 204 NO CONTENT #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mblayman merged 2 commits into django-json-api:develop from dig3:no-content
Apr 16, 2017

Conversation

Copy link

@dig3 dig3 commented Apr 16, 2017

Closes #339

I found this bug while testing an API, and making request with the fetch client provided by React-Native.

This is my first approach to fix the bug. Maybe there is a better way.

Copy link

codecov-io commented Apr 16, 2017 •
edited
Loading

Codecov Report

Merging #340 into develop will increase coverage by 0.13%.
The diff coverage is 84.21%.

Impacted file tree graph 

@@ Coverage Diff @@
## develop #340 +/- ##
===========================================
+ Coverage 72.88% 73.02% +0.13% 
===========================================
 Files 50 50 
 Lines 5676 5690 +14 
===========================================
+ Hits 4137 4155 +18 
+ Misses 1539 1535 -4
Impacted Files Coverage Δ
example/tests/test_views.py 100% <100%> (ø) ⬆️
rest_framework_json_api/renderers.py 58.11% <62.5%> (+0.16%) ⬆️
rest_framework_json_api/mixins.py 87.5% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d75fcbc...32a366e. Read the comment docs.

Copy link
Collaborator

@dig3 thanks for the contribution! I appreciate the test coverage and reference to the relevant part of the spec.

This looks good to me. 👍

@mblayman mblayman merged commit 7001266 into django-json-api:develop Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /