-
Notifications
You must be signed in to change notification settings - Fork 299
Avoid choices evaluation on relational fields getting field metadata #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mblayman
merged 1 commit into
django-json-api:develop
from
InvGate:fix_schema_choices_on_relations
Apr 14, 2017
Merged
Avoid choices evaluation on relational fields getting field metadata #336
mblayman
merged 1 commit into
django-json-api:develop
from
InvGate:fix_schema_choices_on_relations
Apr 14, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## develop #336 +/- ## =========================================== - Coverage 91.68% 72.88% -18.8% =========================================== Files 50 50 Lines 2368 5676 +3308 =========================================== + Hits 2171 4137 +1966 - Misses 197 1539 +1342
Continue to review full report at Codecov.
|
Looks good to me. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On relation fields line 131 is getting all the related objects.