-
Notifications
You must be signed in to change notification settings - Fork 299
Use 'page_query_param' for pagination instead of hard coded page #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
*** What - Use self.page_query_param to determine the query parameter to use for pagination - Set the default page_query_param to 'page' - Freeze fake-factory version to 0.7.4 *** Why - Allow the use of different page query parameters to do pagination - The latest version of fake-factory is now depreciated: https://pypi.python.org/pypi/fake-factory/9999.9.9
Codecov Report
@@ Coverage Diff @@ ## develop #312 +/- ## ======================================== Coverage 91.64% 91.64% ======================================== Files 50 50 Lines 2359 2359 ======================================== Hits 2162 2162 Misses 197 197
Continue to review full report at Codecov.
|
@RegionSyx Thanks for the contribution! Could you make a few changes?
- Replace the pinned
fake-factorydependency with its replacementFaker(sans pinning). - Add documentation to the Usage area where pagination is mentioned.
- Remove the default as that same value is set in the base class coming from DRF.
I'll be happy to merge once those changes are made. 👍
@RegionSyx This branch is now in conflict with the main branch. Could you update the branch to resolve the conflicts and address the other review comments? Once that is done, I'll be able to merge this branch. Thanks.
Lookin' good! Thanks @RegionSyx. 👍
What
pagination
Why
https://pypi.python.org/pypi/fake-factory/9999.9.9