-
Notifications
You must be signed in to change notification settings - Fork 299
Refactor tests. #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor tests. #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.55% (diff: 100%)
@@ develop #310 diff @@ ========================================== Files 49 49 Lines 2330 2310 -20 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== - Hits 2133 2115 -18 + Misses 197 195 -2 Partials 0 0
Powered by Codecov. Last update c869f34...4b0dcc5
abdulhaq-e
added a commit
to abdulhaq-e/django-rest-framework-json-api
that referenced
this pull request
Feb 3, 2017
abdulhaq-e
referenced
this pull request
in abdulhaq-e/django-rest-framework-json-api
Feb 3, 2017
This seems reasonable to me. Comparing native data structures feels like a good fit compared to giant string comparison. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytest gives cleaner output if you compare list/dictionaries instead of dumped jsons. It is also easier to read tests.