Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Serializermethod links #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisclark merged 3 commits into django-json-api:develop from Anton-Shutik:serializermethod-links
Nov 8, 2016
Merged

Serializermethod links #294

chrisclark merged 3 commits into django-json-api:develop from Anton-Shutik:serializermethod-links
Nov 8, 2016

Conversation

Copy link
Contributor

@Anton-Shutik Anton-Shutik commented Oct 19, 2016

Added self and related links to SerializerMethodResourceRelatedField

Copy link

codecov-io commented Oct 19, 2016
edited
Loading

Current coverage is 91.47% (diff: 100%)

Merging #294 into develop will increase coverage by 0.31%

@@ develop #294 diff @@
==========================================
 Files 49 49 
 Lines 2295 2298 +3 
 Methods 0 0 
 Messages 0 0 
 Branches 0 0 
==========================================
+ Hits 2092 2102 +10 
+ Misses 203 196 -7 
 Partials 0 0 

Powered by Codecov. Last update 1623942...3539739

Copy link
Contributor Author

@jerel Any thought on that ? I find it very useful :)

Copy link
Contributor Author

Anton-Shutik commented Oct 25, 2016
edited
Loading

@jsenecal , @leifurhauks What are your thoughts on the PR ?

Copy link
Member

Hi @Anton-Shutik - @leifurhauks and I are a bit out of the loop on that project - sorry that we can't help further.

Copy link
Collaborator

@jerel are you the right person to take a look at this?

Also, if some of the other guys are backing away from the project, would you be willing to add a couple of our folks (@Anton-Shutik, @noazark, me) as maintainers so we can review and merge PRs? We're very committed to this project and have a large production app using it (www.grove.co). @noazark has been using json-api even before the official spec was finished by Yehuda, and is involved in the ember community.

Copy link
Member

jerel commented Oct 28, 2016

@chrisclark sure, I'm still using this project and mean to maintain it but I have a lot on my plate right now and would appreciate if others can dig in and keep it moving. It seems to be to a point where it has 90% of the features that everyone needs and 100% of what my current project needs so I'm often not scratching my own itch by merging a PR.

I've given several of you commit access.

Copy link
Collaborator

Thanks @jerel. We've now been using this in production for a couple of weeks. That along with the test coverage @Anton-Shutik provided, gives me a lot of confidence to merge. Doing so now.

@chrisclark chrisclark merged commit 1941c34 into django-json-api:develop Nov 8, 2016
Copy link
Member

jerel commented Nov 8, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /