Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Implemented py.test runner in setup.py #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerel merged 2 commits into django-json-api:develop from georgemarshall:feature/pytest-runner
Aug 18, 2016

Conversation

Copy link
Contributor

@georgemarshall georgemarshall commented Aug 16, 2016
edited
Loading

Other highlights:

  • Switched to travis build matrix from tox
  • Removed runtest.py blob
  • Updated tox.ini to reflect documented version compatibility

Suggestions:

Copy link

codecov-io commented Aug 16, 2016
edited
Loading

Current coverage is 90.37% (diff: 100%)

No coverage report found for develop at c83b69e.

Powered by Codecov. Last update c83b69e...f98591b

Copy link
Member

jerel commented Aug 16, 2016

@scottfisk what do you think of these changes? I'm happy with merging them if you are.

@@ -1,8 +1,8 @@
[tox]
envlist =
py{27,33,34}-django17-drf{31,32},
Copy link
Contributor

@scottfisk scottfisk Aug 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgemarshall It looks like python 3.2 wasn't in the environments before here or travis.yml Since one of your suggestions was to remove it, we can probably just leave it out?

We should probably remove any other references to python 3.2 while we are at it.

Copy link
Contributor Author

@georgemarshall georgemarshall Aug 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, you're right... Must of stayed up later than I should have.

Copy link
Contributor

scottfisk commented Aug 16, 2016
edited
Loading

@georgemarshall I do like the coverage reporting as well 👍

@jerel Dropped one comment in re python 3.2

Copy link
Contributor Author

Any feedback on Django 1.7 EOL?

Copy link
Contributor

scottfisk commented Aug 16, 2016
edited
Loading

@georgemarshall I was the only one using it last time we did a poll. We am now using 1.9, so I am ok with dropping it.

@jerel jerel merged commit aa66a34 into django-json-api:develop Aug 18, 2016
@georgemarshall georgemarshall deleted the feature/pytest-runner branch August 18, 2016 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /