-
Notifications
You must be signed in to change notification settings - Fork 299
Convert include queries back to snake case #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@scottfisk what are your thoughts on this? This one would be easy to merge but it looks like we also have related work at #204
@jerel I wrote this up before I saw #204
It seems that #204 is taking things further by also reversing pluralization and adding a setting to specify which format the keys should be reverted to. In my opinion, the effort of that PR should be expanded to the other areas that perform this behavior, namely parsing. This could then be considered a stopgap until that larger development is ready.
Uh oh!
There was an error while loading. Please reload this page.
In parsers, we convert incoming keys to snake case (undoing whatever formatting was done during rendering). However, include parameters have to exactly match the fields of models/serializers.
This PR brings the same reversal behavior to include parameters as its done for attributes, etc.
Example:
?include[firstName]===?include[first_name]=