Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed get_resource_name in case of non-model backed serializer. #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerel merged 1 commit into django-json-api:develop from scottfisk:fix-219
Apr 8, 2016

Conversation

Copy link
Contributor

@scottfisk scottfisk commented Apr 8, 2016

Fixed get_resource_name in case of non-model backed serializer. Seems that getattr evaluates the default regardless of whether the default case is used (Similar SO Question). For serializers without a meta.Model this poses a problem.

Closes #219

craigteegarden reacted with thumbs up emoji
Copy link
Member

jerel commented Apr 8, 2016

@scottfisk thanks! This looks good, I'll merge as soon as tests finish

@jerel jerel merged commit d08e9f3 into django-json-api:develop Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /