-
Notifications
You must be signed in to change notification settings - Fork 299
Deprecated support for django-polymorphic resources #1303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Desired for Django Polymorphic support to be added in an external 3rd party library in case there is a demand and someone is to be found who will take the lead.
@n2ygk Please let me know what you think about this deprecation strategy before you merge, whether you think that is a good way forward or have any other suggestions? Thanks.
It seems like a very lightly used feature if at all and pretty impactful in terms of added DJA support complexity. It's not even clear from #1087 (comment) whether @Elawphant is still relying on it (past tense use of "was").
The deprecation warnings are certainly the best way to get anyone's attention to determine the potential impact. I'm OK with merging this as is. Let me know if you want me to go ahead.
Good that we are on the same page. Let's go ahead and merge it then.
Description of the Change
I have started discussion #1194 almost two years ago in terms of Django Polymorphic support in DJA and what it is used for. I have pinged people in the different PRs and issues about Polymorphic. The only response I got is at #1087 (comment), but otherwise no feedback.
My feeling is that either Django Polymorphic support in DJA is not really used or people are not aware of the surrounding discussion.
The goal of deprecation is that users who use it will become aware of the discussion, and we get a group of people who hopefully will be able to work on Django Polymorphic support in an external library.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS