-
Notifications
You must be signed in to change notification settings - Fork 299
Removed built-in OpenAPI support #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
027b4eb
to
35269c5
Compare
@n2ygk Just saw that I missed removing some code, pushed that now. In case you consider this for merging, could you also test in an actual project that schema generation still works with drf-spectacular-json-api and these changes?
I do not have an actual project, so won't be able to check on that.
@n2ygk Just saw that I missed removing some code, pushed that now. In case you consider this for merging, could you also test in an actual project that schema generation still works with drf-spectacular-json-api and these changes? I do not have an actual project, so won't be able to check on that.
Looks like breaking changes to setuptools that I have to resolve first... It has to do with setuptools no longer accepting local filesystem paths.
Tested locally without using tox and it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tested my demo project to confirm that nothing breaks.
Not sure if we want to document the new way using drf-spectacular-jsonapi but that is certainly appropriate for a separate documentation PR if deemed useful.
Uh oh!
There was an error while loading. Please reload this page.
Description of the Change
Planning a new major release 8.0.0 I thought it is time to also remove built-in OpenAPI support as it has been deprecated for quite a while now and it also does not work with the newest django-filter version anymore.
In case there are any concerns removing it please let me know.
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS