-
Notifications
You must be signed in to change notification settings - Fork 299
Fix the inclusion of relations #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When getting a list and including data from the models in the list, only the related data of the first model in the list was included
@jsenecal I'm 👍 on this if you want to review and merge
Have you tried setting a path in the include parameter? Like so: include=blog.author otherwise I don't understand your issue
|
Assuming table
and table
Now let's do Gives roughly following result (I wrote this from memory ): {
"data": [{
"type": "persons",
"id": 1,
"attributes": { "name": "John" },
"relationships": {
"fruit": {
"data": { "type": "fruit", "id": "1" }
}
}
},
{
"type": "persons",
"id": 2,
"attributes": { "name": "Jack" },
"relationships": {
"fruit": {
"data": { "type": "fruit", "id": "1" }
}
}
},
{
"type": "persons",
"id": 3,
"attributes": { "name": "Jill" },
"relationships": {
"fruit": {
"data": { "type": "fruit", "id": "2" }
}
}
}
# so far so good, now here it gets interesting
],
"included": [{
"type": "fruit",
"id": 1,
"attributes": {
"name": "apple"
}
}]
# banana is missing, even though the person 3 references it
}, |
Fix the inclusion of relations
@jsenecal oh, sorry this is an error. It would be /api/v1/person of course.
When getting a list and including data from the models in the list, only
the related data of the first model in the list was included
Explanation:
Let's assume a Model
Mthat has a foreign keytypereferencingType. Now we get a list ofMwhich have different types and include the types (?include=type), only theTypeof the first reference will be included, because of line 417.