Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Migrated some included tests to pytest style #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 1 commit into django-json-api:main from sliverc:include_tests
Apr 17, 2024

Conversation

Copy link
Member

@sliverc sliverc commented Apr 17, 2024

Related to #468

Description of the Change

This is only a partial rewrite of the included tests. More will follow later. Merging this though that we can move forward implementing #1004 which is a regression.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk April 17, 2024 20:16
@n2ygk n2ygk merged commit f34fb42 into django-json-api:main Apr 17, 2024
Copy link
Contributor

n2ygk commented Apr 17, 2024

codecov appeared to be stuck so I force-merged given the nature of the changes.

sliverc reacted with thumbs up emoji

@sliverc sliverc deleted the include_tests branch April 17, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /