-
Notifications
You must be signed in to change notification settings - Fork 298
Made docs/requirements.txt obsolete and install project itself #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/requirements.txt was only introduced as it was only possible to configure one requirements in the web interface. In the yaml file it is possible to add several therefore removing docs/requirements.txt
n2ygk
n2ygk
approved these changes
Feb 21, 2023
Thanks for merging those PRs. Finally, the RTD build is passing again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
docs/requirements.txt was only introduced as it was only possible to configure one "requirements.txt" in the web interface. In the yaml file it is possible to add several, therefore removing docs/requirements.txt.
Additionally, this should solve the still persistent build error, as the project itself also needs to be installed.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS